bito-code-review[bot] commented on PR #41295:
URL: https://github.com/apache/superset/pull/41295#issuecomment-4774278992

   <!-- Bito Reply -->
   The suggestion to add type hints to the new test method is correct, as it 
improves code quality and consistency. You can resolve this by updating the 
method signature to include `self: Any` and `-> None`.
   
   ```python
       def test_show_roles_unexpected_error_returns_generic_message(self: Any) 
-> None:
   ```
   
   There are no other comments on this pull request. Would you like me to 
implement this change for you?
   
   **tests/integration_tests/security/api_tests.py**
   ```
   def test_show_roles_unexpected_error_returns_generic_message(self: Any) -> 
None:
           """
           Security API: an unexpected error in role listing returns a generic 
500
           body (no raw exception text) and is logged server-side.
           """
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to