codeant-ai-for-open-source[bot] commented on code in PR #41296:
URL: https://github.com/apache/superset/pull/41296#discussion_r3456209084
##########
tests/unit_tests/mcp_service/test_jwt_verifier.py:
##########
@@ -83,6 +83,29 @@ async def test_algorithm_mismatch(hs256_verifier):
assert "HS256" not in reason
[email protected]
+async def test_unpinned_algorithm_is_rejected(hs256_verifier):
Review Comment:
**Suggestion:** Add full type annotations to the new async test function,
including the `hs256_verifier` parameter type and an explicit `-> None` return
type. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is a newly added Python async test function, and it omits both a
parameter type hint for
`hs256_verifier` and an explicit `-> None` return annotation. That matches
the custom rule
requiring new Python functions to be fully typed.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=f8a6854a69f843b0addda97cd88093c4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=f8a6854a69f843b0addda97cd88093c4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/mcp_service/test_jwt_verifier.py
**Line:** 87:87
**Comment:**
*Custom Rule: Add full type annotations to the new async test function,
including the `hs256_verifier` parameter type and an explicit `-> None` return
type.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41296&comment_hash=e8c1aebd9ddf3e22b252c5951a35439325570d32738072ed97d32fc17fbe9d0e&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41296&comment_hash=e8c1aebd9ddf3e22b252c5951a35439325570d32738072ed97d32fc17fbe9d0e&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
