bito-code-review[bot] commented on PR #41296: URL: https://github.com/apache/superset/pull/41296#issuecomment-4774305849
<!-- Bito Reply --> The suggestion to add type annotations to the new async test function is correct and aligns with best practices for maintaining a typed codebase. You can resolve this by updating the function signature in `tests/unit_tests/mcp_service/test_jwt_verifier.py` as follows: ```python @pytest.mark.asyncio async def test_unpinned_algorithm_is_rejected(hs256_verifier: Any) -> None: ``` (Note: Ensure `Any` is imported from `typing` if not already available in the file.) There are no other comments on this PR to address. Would you like me to proceed with any other changes? **tests/unit_tests/mcp_service/test_jwt_verifier.py** ``` @pytest.mark.asyncio async def test_unpinned_algorithm_is_rejected(hs256_verifier: Any) -> None: ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
