jtjenkins commented on PR #39894:
URL: https://github.com/apache/superset/pull/39894#issuecomment-4774427479
Thanks for the review @rusackas! Addressed in 010f053:
- **Prettier** — re-ran prettier on `FilterValue.tsx`; format check is green
now.
- **`as Record<string, any>` cast** — dropped it. `state.datasources` is
already typed as `DatasourcesState`, so `main_dttm_col` resolves to `string |
undefined` with no `any`.
- **Test coverage** — pinned down both pieces of logic:
- Extracted the granularity resolution into an exported pure
`resolveGranularitySqla()` helper and covered the cascade cases (own value
wins, `main_dttm_col` fallback when a `time_range` parent cascades,
no-dependency, and no-dttm) in `FilterValue.timeGrain.test.ts`.
- Added `datasources.test.ts` for the in-flight dedup `Set`: cache-hit
short-circuit, single fetch, concurrent de-duplication of the same key, and key
cleanup after a failed request so it can retry.
The bot's dedup suggestion was already implemented in b582c8a (the in-flight
`Set`), so no functional change needed there — just the test pinning it down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
