rusackas commented on PR #39894: URL: https://github.com/apache/superset/pull/39894#issuecomment-4773879444
Prettier is failing on `FilterValue.tsx` — a quick `pre-commit run prettier` should sort that out and get CI green. The `state.datasources as Record<string, any>` cast is the bit I'd want to lose before we merge — we're trying to get away from `any`, and the new `main_dttm_col` fallback plus the in-flight dedup `Set` are exactly the kind of logic I'd want a test pinning down. Can you add coverage for the cascade case? (The playwright/cypress reds look like the usual flaky export/delete suites, not your change — don't sweat those.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
