EnxDev opened a new pull request, #41342: URL: https://github.com/apache/superset/pull/41342
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY Big Number with Time Comparison (`pop_kpi`) ignores `extra_form_data.time_compare`. When that override is set, the chart still computes its comparison from its own `time_compare` control, so the displayed comparison value, delta, and "Data for …" tooltip don't reflect the override. ### Fix Read `extra_form_data.time_compare` and let it drive the comparison, mirroring how the Table chart already handles it (#33947): - **buildQuery.ts** — when `extra_form_data.time_compare` is present, use it as `time_offsets` (and request offsets in that case) so the backend computes the comparison against the overridden range. - **transformProps.ts** — prefer `extra_form_data.time_compare` when selecting the comparison column and computing the tooltip shift. - Added a `buildQuery` test covering the override. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> With `extra_form_data.time_compare` set, the Big Number's comparison value, delta, and percent now match the Table chart for the same data. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
