pSpitzner opened a new pull request, #41341:
URL: https://github.com/apache/superset/pull/41341
This PR proposes a minimaly invasive fix for #41283.
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
In the deck.gl geojson polygon chart, we now add the specified metric (used
to generate the color of the polygons) as the last element of the tooltip. This
avoids a custom tooltip template — which would require disabeling or adjusing
CSP.
- Only applies if no tooltip template is specified
- In this case, makes the template used when "tooltip content" is given
(e.g. metadata) more consistent with:
- what can be done with a custom template — where metrics are available as
`{{ custom_metric }}`
- the default tooltip when no "tooltip content" is specified — which
includes the metric as the second row
### NOTES
- I considered adding more controls to toggle this on and off, via the
"tooltip contents". But the code changes were much deeper (because the "tooltip
content" selection component is quite involved, and this needs to cover more
edge cases than i would like). I think the proposed fix is a sensible default.
- This is my first PR to superset. Since I am new to the codebase, I left
some verbose comments to explain my thinking for potential reviewers. @rusackas
@DamianPendrak @geido
### SCREENSHOTS
<!--- Skip this if not applicable -->
Before:
<img width="500" alt="screenshot_2026-06-23_161650@2x"
src="https://github.com/user-attachments/assets/4b42c916-a544-4662-b0ee-7be52bb1b386";
/>
After:
<img width="500" alt="screenshot_2026-06-23_161917@2x"
src="https://github.com/user-attachments/assets/b637d817-f71d-41f8-97e9-926867500d06";
/>
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- Fixes #41283
- [ ] Required feature flags:
- [x] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
