rusackas commented on PR #38165: URL: https://github.com/apache/superset/pull/38165#issuecomment-4784953099
@kimsehwan96 just checking in on this PR again :) Thanks for the help here. The reuse branch renders `chart.queriesResponse` and never looks at `cappedFormData`, and `queriesResponse` won't change when only the Results-tab row-limit dropdown moves. On a v1 chart, lowering that limit seems like it wouldn't do anything. Can you confirm the dropdown still works on the reuse path, and add a test covering reuse vs fallback? Happy to help if help is needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
