kimsehwan96 commented on code in PR #38165:
URL: https://github.com/apache/superset/pull/38165#discussion_r3471131016
##########
superset-frontend/playwright/pages/ExplorePage.ts:
##########
@@ -106,4 +113,53 @@ export class ExplorePage {
getVizSwitcher(): Locator {
return this.page.locator(ExplorePage.SELECTORS.VIZ_SWITCHER);
}
+
+ /**
+ * Expands the bottom data panel if it is currently collapsed.
+ * Safe to call when already expanded (no-op).
+ */
+ async expandDataPanel(): Promise<void> {
+ const expandButton = this.page.locator(
+ ExplorePage.SELECTORS.EXPAND_DATA_PANEL,
+ );
+ if (await expandButton.isVisible().catch(() => false)) {
+ await expandButton.click();
+ }
+ }
+
+ /**
+ * Opens the bottom data panel (if needed) and activates the "Results" tab.
+ */
+ async openResultsTab(): Promise<void> {
+ await this.expandDataPanel();
+ const resultsTab = this.page
+ .locator(ExplorePage.SELECTORS.SOUTH_PANE)
+ .locator(ExplorePage.SELECTORS.RESULTS_TAB);
+ await resultsTab.click();
+ }
Review Comment:
Done:
https://github.com/apache/superset/compare/61ff26ecf7cbd4735c9a2833f140f72be5b8373a..875b08bb84c6bd0fbe3fd0cdb850443ed9b968a9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
