bito-code-review[bot] commented on code in PR #32487: URL: https://github.com/apache/superset/pull/32487#discussion_r3464993046
########## docs/admin_docs/configuration/event-logging.mdx: ########## @@ -50,13 +50,28 @@ Superset can be configured to log events to [StatsD](https://github.com/statsd/s if desired. Most endpoints hit are logged as well as key events like query start and end in SQL Lab. -To setup StatsD logging, it’s a matter of configuring the logger in your `superset_config.py`. -If not already present, you need to ensure that the `statsd`-package is installed in Superset's python environment. +By default, Superset also collects gunicorn [metrics](https://docs.gunicorn.org/en/stable/instrumentation.html). Review Comment: <div> <div id="suggestion"> <div id="issue"><b>CWE-20: Broken documentation link</b></div> <div id="fix"> The link to gunicorn instrumentation docs returns HTTP 404. The correct URL is https://gunicorn.org/instrumentation/ ([CWE-20](https://cwe.mitre.org/data/definitions/20.html)) </div> <details> <summary> <b>Code suggestion</b> </summary> <blockquote>Check the AI-generated fix before applying</blockquote> <div id="code"> ``` --- docs/admin_docs/configuration/event-logging.mdx +++ docs/admin_docs/configuration/event-logging.mdx @@ -50,7 +50,7 @@ if desired. Most endpoints hit are logged as well as key events like query start and end in SQL Lab. -By default, Superset also collects gunicorn [metrics](https://docs.gunicorn.org/en/stable/instrumentation.html). +By default, Superset also collects gunicorn [metrics](https://gunicorn.org/instrumentation/). To enable these, the following environment variables should be set: ``` </div> </details> </div> <small><i>Code Review Run #1737dc</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
