chollinger93 commented on PR #32487: URL: https://github.com/apache/superset/pull/32487#issuecomment-4790702781
@rusackas sorry, I've been a bit too busy these last few months, so I haven't really followed up here. Regarding the config conversation, using `extraEnv` (which presumably would work in either deployment mode) still seems like a simple and pragmatic approach here, not only since I unfortunately won't have time to work on any deeper integration. This _should_ also carry over to an operator based approach @villebro ? I've made `SERVER_STATSD_HOST` explicitly opt-in. Expanding `STATSD_ARGS[@]` should be safe, since the script explicitly asks for `bash`. This also fixes 2 of the (valid) concerns the robot had around default exposure/wrong defaults (there no longer is a default). I also trimmed the input. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
