pSpitzner commented on PR #41341: URL: https://github.com/apache/superset/pull/41341#issuecomment-4791595942
I took a spin at the major points: - handle string like metrics - avoid row duplication - avoid `any` casts and handle falsy metrics a bit better I think test coverage could still be improved on the tooltipUtils, but I focused on the branches I touched. On the ohter hand, I am not sure if we want to add tests for `extraValues()` as suggested by the bito-code-review bot, felt a bit overkill to me. Im out of office for a few days. So if we want to tweak a bit more: feel free to push changes, or I can look at the end of next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
