Copilot commented on code in PR #41177:
URL: https://github.com/apache/superset/pull/41177#discussion_r3471018026
##########
superset/commands/report/execute.py:
##########
@@ -1176,6 +1207,18 @@ def run(self) -> None:
if not self._model:
raise ReportScheduleExecuteUnexpectedError()
+ # Resolve the executor at the run() boundary the same way master
+ # does: tolerate a missing user (find_user -> None) so the state
+ # machine still runs and its error envelope writes the ERROR
+ # execution-log row and sends the owner notification. The dedicated
+ # ReportScheduleExecutorNotFoundError guard lives at the content
+ # sites (_get_screenshots / _get_csv_data / _get_embedded_data),
+ # which raise inside that envelope. Guarding here instead would
+ # surface the executor error above the state machine, suppressing
+ # both the log row and the owner notification. The alert-query path
+ # (AlertCommand) is intentionally left on master behavior — a
+ # missing executor there surfaces as a query error, not the
+ # dedicated executor error; tightening it is out of scope here.
Review Comment:
The new comment block references “master behavior”, which is branch-specific
and can become misleading as behavior evolves. Consider rephrasing to describe
the rationale without tying it to the current default branch name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
