sadpandajoe commented on PR #41177:
URL: https://github.com/apache/superset/pull/41177#issuecomment-4783637174
Thanks for the careful review — all three points are addressed in the latest
push.
**`_FakeBackoffDatetime` → `freezegun`.** Agreed on the fragility of
patching `backoff._sync.datetime` (a private import that a dep bump could
rename). The helper and the `monkeypatch.setattr("backoff._sync.datetime",
...)` calls are gone; the clock tests now use `freezegun.freeze_time`, which
patches `datetime.datetime.now` at the stdlib level so `backoff` picks it up
with no coupling to its internals. The persistent-fail and recovering tests
advance the clock via `auto_tick_seconds`, and the assertions are
property-based (a bounded range / a mock-governed count) rather than pinned
tick counts, since freezegun's per-access tick count is an implementation
detail. Each test was confirmed to fail when `max_time` is removed or lowered,
so the bound still has real coverage.
**~180s effective ceiling.** Good catch, and the framing was meant to be
approximate. `max_time=120` bounds *accounted* retry time, but since it's
checked between attempts and each request carries `timeout=60`, a
consistently-hanging target can run ~180s worst case (the final in-flight
request runs out its own timeout after the bound fires). I've reworded the PR
description (and the admin docs) to state the ~180s worst case explicitly
rather than implying a hard 120s.
**Empty-username message.** Fixed — `ReportScheduleExecutorNotFoundError`
now falls back to `(unknown)` when no username is available, so the message
reads cleanly, with a small regression test covering it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
