sha174n opened a new pull request, #41425:
URL: https://github.com/apache/superset/pull/41425

   ### SUMMARY
   Applies the same per-datasource access check the `/api/v1/explore` command 
uses (`security_manager.raise_for_access(datasource=...)`) to the deprecated 
`/superset/explore/` view, so both paths apply a consistent per-object 
datasource check before rendering datasource metadata. The check is guarded for 
the placeholder (missing-dataset) case the view already supports, and runs 
ahead of the save-as/overwrite action paths so they share the same check.
   
   ### TESTING INSTRUCTIONS
   Adds a regression test asserting the view runs the per-datasource check on 
the loaded datasource:
   
   `pytest 
tests/integration_tests/core_tests.py::TestCore::test_explore_view_checks_datasource_access`
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to