bito-code-review[bot] commented on PR #41425:
URL: https://github.com/apache/superset/pull/41425#issuecomment-4803612895
<!-- Bito Reply -->
The flagged issue is correct. The test method
`test_explore_view_checks_datasource_access` lacks type annotations for the
`mock_raise_for_access` parameter and the return type. You can resolve this by
updating the method signature as follows:
```python
@mock.patch("superset.security.SupersetSecurityManager.raise_for_access")
def test_explore_view_checks_datasource_access(self,
mock_raise_for_access: mock.Mock) -> None:
```
There are no other comments on this pull request to address.
**tests/integration_tests/core_tests.py**
```
@mock.patch("superset.security.SupersetSecurityManager.raise_for_access")
def test_explore_view_checks_datasource_access(self,
mock_raise_for_access: mock.Mock) -> None:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
