bito-code-review[bot] commented on PR #41428:
URL: https://github.com/apache/superset/pull/41428#issuecomment-4802013928
<!-- Bito Reply -->
The flagged issue is correct. The current implementation adds a second
`wait_for_timeout` call in the non-tiled flow, which results in double the
configured `SCREENSHOT_SELENIUM_ANIMATION_WAIT` delay. To resolve this, the
initial unconditional wait should be removed, and the delay should be applied
only once after the spinners have cleared.
To implement this, remove the early `page.wait_for_timeout` call (which
occurs before branching) and ensure the wait only happens in the post-spinner
location as added in this PR. Would you like me to fetch all other comments on
this PR to validate and implement fixes for them as well?
**superset/utils/webdriver.py**
```
# Remove the early unconditional wait (typically found earlier in the
method):
# page.wait_for_timeout(selenium_animation_wait * 1000)
# Keep the post-spinner wait as implemented in the PR:
if selenium_animation_wait > 0:
page.wait_for_timeout(selenium_animation_wait * 1000)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
