bito-code-review[bot] commented on PR #41403:
URL: https://github.com/apache/superset/pull/41403#issuecomment-4802434014
<!-- Bito Reply -->
The suggestion to update the `syncQueryEditor` test is appropriate.
Currently, the test does not explicitly model preview queries with
`isDataPreview: true`, which means the new exclusion logic
(`!query.isDataPreview`) is not being verified against actual preview query
objects. Updating the test to include a mock preview query (with
`isDataPreview: true` and `sqlEditorId: null`) would ensure that preview
queries are correctly excluded from migration, while still verifying that
standard running queries are migrated as expected.
**superset-frontend/src/SqlLab/actions/sqlLab.test.ts**
```
{
...query,
id: 'previewQuery',
sqlEditorId: null,
isDataPreview: true,
},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
