sadpandajoe commented on code in PR #41403:
URL: https://github.com/apache/superset/pull/41403#discussion_r3476654478
##########
superset-frontend/src/SqlLab/actions/sqlLab.ts:
##########
@@ -689,8 +689,8 @@ export function syncQueryEditor(
(table: Table) =>
table.inLocalStorage && table.queryEditorId === queryEditor.id,
);
- const localStorageQueries = Object.values(queries).filter(
- query => query.inLocalStorage && query.sqlEditorId === queryEditor.id,
+ const queriesToMigrate = Object.values(queries).filter(
+ query => query.sqlEditorId === queryEditor.id && !query.isDataPreview,
);
Review Comment:
Fixed in a2241b1341: the syncQueryEditor test now models data-preview
queries with isDataPreview: true and sqlEditorId: null, and asserts only the
non-preview running query is migrated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
