codeant-ai-for-open-source[bot] commented on code in PR #39914:
URL: https://github.com/apache/superset/pull/39914#discussion_r3476539163
##########
tests/integration_tests/reports/commands_tests.py:
##########
@@ -1978,11 +1978,13 @@ def test_slack_chart_alert_no_attachment(email_mock,
create_alert_email_chart):
"load_birth_names_dashboard_with_slices",
"create_report_slack_chart",
)
+@patch("superset.commands.report.execute.get_channels_with_search")
@patch("superset.utils.slack.WebClient")
@patch("superset.utils.screenshots.ChartScreenshot.get_screenshot")
def test_slack_token_callable_chart_report(
screenshot_mock,
slack_client_mock_class,
+ get_channels_with_search_mock,
create_report_slack_chart,
Review Comment:
**Suggestion:** Add a type annotation for the newly introduced function
parameter so the modified function signature remains fully typed. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The PR modifies this test function's signature by adding a new parameter,
but the parameter is not type-annotated. Since the surrounding Python code is
being changed, the custom rule requires the new or modified function signature
to remain fully typed. This is a real rule violation.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=f545ebe652504d86b6a3e74d8ef259f2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=f545ebe652504d86b6a3e74d8ef259f2&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/integration_tests/reports/commands_tests.py
**Line:** 1984:1988
**Comment:**
*Custom Rule: Add a type annotation for the newly introduced function
parameter so the modified function signature remains fully typed.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39914&comment_hash=718295fb943906156b9a7d99384e004984a62d7c1bca9b25b9c08985b13de8a5&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F39914&comment_hash=718295fb943906156b9a7d99384e004984a62d7c1bca9b25b9c08985b13de8a5&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
