aminghadersohi commented on PR #38576: URL: https://github.com/apache/superset/pull/38576#issuecomment-4803596254
Thanks Richard — addressed all three in commit `17690c7c`: 1. **Imports moved to module scope** — no circular import exists, so removed the `import-outside-toplevel` suppression and moved both `DistributedLock` and `AcquireDistributedLockFailedException` to the top of `screenshots.py`. 2. **Test assertion tightened** — `test_cache_dashboard_thumbnail_resolves_cache_key_when_not_provided` now uses `assert_called_once_with(...)` including `cache_key="resolved_cache_key"`, so it will catch any regression where the resolved key is not propagated into `compute_and_cache`. 3. **PR description updated** — rewritten to describe the final design accurately: API check is optimization-only, correctness lives in the `DistributedLock` inside `compute_and_cache`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
