aminghadersohi commented on code in PR #38576:
URL: https://github.com/apache/superset/pull/38576#discussion_r3477456969
##########
tests/unit_tests/utils/test_screenshot_cache_fix.py:
##########
@@ -27,13 +27,15 @@
import pytest
from pytest_mock import MockerFixture
+from superset.exceptions import AcquireDistributedLockFailedException
from superset.utils.screenshots import (
BaseScreenshot,
ScreenshotCachePayload,
StatusValues,
)
BASE_SCREENSHOT_PATH = "superset.utils.screenshots.BaseScreenshot"
+DISTRIBUTED_LOCK_PATH = "superset.distributed_lock.DistributedLock"
Review Comment:
Fixed in 9f712b5 — changed DISTRIBUTED_LOCK_PATH to
superset.utils.screenshots.DistributedLock to match the module-level import in
screenshots.py. The test now correctly patches where the name is used rather
than where it is defined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
