manojshetty2004 commented on PR #38657: URL: https://github.com/apache/superset/pull/38657#issuecomment-4810756617
> Thanks @manojshetty2004, appreciate you sticking with this one. > > I'm a little confused on the direction though. #37286 is about the zoom control clipping in _short_ panels, but `Math.max(zoomBottom, Math.floor(height * 0.08))` only raises `bottom` as height grows, so a 300px panel still resolves to the old `30` and the test's `smallBottom` is unchanged. Taller charts get a bigger bottom margin instead. Can you walk me through how that fixes the clipped case? :) > > Also this needs a rebase, it's conflicting with current `master` so we can't merge as-is. Thanks for the clarification and for pointing that out. You're right—my current approach doesn't address the clipping issue in shorter panels, and I misunderstood the root cause. I'll revisit the issue, investigate the clipping behavior again, and work on a more appropriate fix. I'll also rebase the PR onto the latest master and push an updated implementation once I have a better solution. Thanks again for the detailed review and guidance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
