sadpandajoe commented on code in PR #41421:
URL: https://github.com/apache/superset/pull/41421#discussion_r3484168857
##########
superset/db_engine_specs/databricks.py:
##########
@@ -474,6 +579,74 @@ class
DatabricksNativeEngineSpec(DatabricksDynamicBaseEngineSpec):
supports_dynamic_catalog = True
supports_cross_catalog_queries = True
+ # OAuth 2.0 support
+ supports_oauth2 = True
+ oauth2_exception = OAuth2RedirectError
Review Comment:
`oauth2_exception` should be the Databricks driver auth exception that tells
Superset to start the OAuth dance, right? Setting it to `OAuth2RedirectError`
looks backwards. A real no-token/expired-token Databricks failure won’t match
`needs_oauth2()` and won’t bootstrap the OAuth flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
