rusackas commented on code in PR #41421:
URL: https://github.com/apache/superset/pull/41421#discussion_r3485680276
##########
superset/db_engine_specs/databricks.py:
##########
@@ -277,6 +284,135 @@ class
DatabricksDynamicBaseEngineSpec(BasicParametersMixin, DatabricksBaseEngine
"port": "port",
}
+ # The Databricks SQL driver has no dedicated authentication exception, so
an
+ # expired or missing token surfaces as a generic driver error. These case-
+ # insensitive substrings flag the errors that should bootstrap a re-auth.
+ oauth2_auth_failure_signals = (
+ "401",
+ "unauthorized",
+ "unauthenticated",
+ "invalid access token",
+ "invalid token",
+ "expired token",
+ "token expired",
Review Comment:
Good catch, a bare `401` could match something like a line number. Tightened
it to `http 401` in `04996268` (the canonical message still carries
`unauthorized` anyway), with a regression test for the false positive. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
