codeant-ai-for-open-source[bot] commented on code in PR #41487:
URL: https://github.com/apache/superset/pull/41487#discussion_r3485745680
##########
tests/unit_tests/async_events/async_query_manager_tests.py:
##########
@@ -222,6 +222,44 @@ def
test_parse_channel_id_from_request_as_guest_user_differs_per_token(
assert first != second
[email protected]("superset.is_feature_enabled")
+def test_parse_channel_id_from_request_as_guest_user_differs_per_scope(
+ is_feature_enabled_mock, async_query_manager
+):
Review Comment:
**Suggestion:** Add full type annotations to the new test function
signature, including parameter types and an explicit `-> None` return type.
[custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is a newly added Python function and it lacks type annotations for both
parameters and the return type, which violates the rule that new Python code
should be fully typed.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=5bb1bddad8734824b3b4e97a386a255c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=5bb1bddad8734824b3b4e97a386a255c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/async_events/async_query_manager_tests.py
**Line:** 226:228
**Comment:**
*Custom Rule: Add full type annotations to the new test function
signature, including parameter types and an explicit `-> None` return type.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41487&comment_hash=78312845fa979f09ded0bd5c4ae4f0247b9fd6dd15ebce0570499b2896d6b0a9&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41487&comment_hash=78312845fa979f09ded0bd5c4ae4f0247b9fd6dd15ebce0570499b2896d6b0a9&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
