bito-code-review[bot] commented on PR #41487:
URL: https://github.com/apache/superset/pull/41487#issuecomment-4816355762
<!-- Bito Reply -->
The flagged issue is correct. The new test function
`test_parse_channel_id_from_request_as_guest_user_differs_per_scope` lacks type
annotations for its parameters and return type. You can resolve this by adding
the necessary type hints as shown below:
```python
@mock.patch("superset.is_feature_enabled")
def test_parse_channel_id_from_request_as_guest_user_differs_per_scope(
is_feature_enabled_mock: mock.Mock, async_query_manager:
AsyncQueryManager
) -> None:
```
There are no other comments on this PR to address. Would you like me to
check for any other potential improvements in this file?
**tests/unit_tests/async_events/async_query_manager_tests.py**
```
@mock.patch("superset.is_feature_enabled")
def test_parse_channel_id_from_request_as_guest_user_differs_per_scope(
is_feature_enabled_mock: mock.Mock, async_query_manager:
AsyncQueryManager
) -> None:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
