rusackas commented on PR #37777: URL: https://github.com/apache/superset/pull/37777#issuecomment-4816377022
I went ahead and adopted this to get it over the line, @KH-Coder865 (thanks for the original fix!). Rebased on current master and cleaned up the prettier indentation that was failing pre-commit, then flipped it back to ready for review. On the bot threads: the CodeAnt "actions is undefined" flag doesn't apply to the current diff (the props we actually drop from the `useResultsPane` call are `setForceQuery` and `isVisible`, not `actions`). The Bito note about state loss on tab switch is the real one worth a look: rendering inactive panes as `null` does unmount them, so something like the filter text in a result pane resets when you switch tabs. That's inherent to the hide-inactive approach here, and I think it's an acceptable tradeoff for not rendering all the result tables at once, but happy to hear if anyone feels we should preserve that state instead. Running CI now 🤞 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
