bito-code-review[bot] commented on code in PR #37777:
URL: https://github.com/apache/superset/pull/37777#discussion_r3486003370
##########
superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.tsx:
##########
@@ -188,14 +188,17 @@ export const DataTablesPane = ({
queryForce,
ownState,
isRequest: isRequest.results,
- setForceQuery,
- isVisible: ResultTypes.Results === activeTabKey,
canDownload,
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing setForceQuery prop causes functional
regression</b></div>
<div id="fix">
The `setForceQuery` prop was removed but the `useResultsPane` hook relies on
it to reset the force-query state after successful requests (see lines 97-99,
115-117 in useResultsPane.tsx). Without it, the 'Run' button state won't be
reset after cache hits or successful queries, leaving the chart in
force-refresh mode indefinitely.
</div>
</div>
<small><i>Code Review Run #1be105</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset-frontend/src/explore/components/DataTablesPane/components/useResultsPane.tsx:
##########
@@ -181,7 +181,7 @@ export const useResultsPane = ({
coltypes={result.coltypes}
rowcount={result.rowcount}
datasourceId={queryFormData.datasource}
- isVisible={isVisible}
+ isVisible={isVisible ?? true}
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Type consistency defect</b></div>
<div id="fix">
The fix correctly addresses the type mismatch, but it masks an underlying
type contract inconsistency. `ResultsPaneProps.isVisible` is typed as optional
(`boolean | undefined`) but the parent `DataTablesPane.tsx` never passes this
prop, relying on the fallback at line 184. Consider making the type consistent
with actual usage by removing the optional marker from `ResultsPaneProps` or
documenting the explicit fallback behavior in the interface comment.
</div>
</div>
<small><i>Code Review Run #1be105</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
