bito-code-review[bot] commented on code in PR #32995:
URL: https://github.com/apache/superset/pull/32995#discussion_r3485981629
##########
superset-frontend/src/pages/DatasetList/index.tsx:
##########
@@ -129,27 +129,6 @@ const FlexRowContainer = styled.div`
const Actions = styled.div`
${({ theme }) => css`
color: ${theme.colorIcon};
-
- .disabled {
- svg,
- i {
- &:hover {
- path {
- fill: ${theme.colorText};
- }
- }
- }
- color: ${theme.colorTextDisabled};
- &:hover {
- cursor: not-allowed;
- }
- .ant-menu-item:hover {
- cursor: default;
- }
- &::after {
- color: ${theme.colorTextDisabled};
- }
- }
`}
`;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing disabled CSS styles</b></div>
<div id="fix">
The `.disabled` CSS rules were removed from the `Actions` styled component,
but the `disabled` class is still conditionally applied to both the edit button
(line 898) and delete button (line 955) when `allowEdit` is false. Without
these CSS rules, disabled buttons will display with default cursor and colors
instead of the intended `not-allowed` cursor and muted styling. Restore the
`.disabled` block from lines 132-152 to provide proper visual feedback for
users without edit permissions.
</div>
</div>
<small><i>Code Review Run #f6c3b3</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
