codeant-ai-for-open-source[bot] commented on code in PR #38308:
URL: https://github.com/apache/superset/pull/38308#discussion_r3487336718
##########
superset-embedded-sdk/webpack.config.js:
##########
@@ -17,19 +17,19 @@
* under the License.
*/
-const path = require('path');
+const path = require("path");
Review Comment:
**Suggestion:** Convert this modified JavaScript file to a TypeScript config
file (`webpack.config.ts`) and use typed module syntax so new frontend-side
changes are not added in `.js` files. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This file is a modified JavaScript source file (`webpack.config.js`), and
the rule explicitly requires frontend-side changes to be converted to
TypeScript rather than kept in `.js` files. The violation is present in the
final file state.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=467fad0fb1af4c50bdbf0568f7d038a1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=467fad0fb1af4c50bdbf0568f7d038a1&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-embedded-sdk/webpack.config.js
**Line:** 20:20
**Comment:**
*Custom Rule: Convert this modified JavaScript file to a TypeScript
config file (`webpack.config.ts`) and use typed module syntax so new
frontend-side changes are not added in `.js` files.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38308&comment_hash=3ec910f085025767864bb4a3933536efa1b839e3eea9a09b7e55137bbf731def&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38308&comment_hash=3ec910f085025767864bb4a3933536efa1b839e3eea9a09b7e55137bbf731def&reaction=dislike'>👎</a>
##########
superset-embedded-sdk/release-if-necessary.js:
##########
@@ -17,15 +17,15 @@
* under the License.
*/
-const { execSync } = require('child_process');
-const { name, version } = require('./package.json');
+const { execSync } = require("child_process");
Review Comment:
**Suggestion:** Convert this release script to TypeScript and move it to a
`.ts` file instead of adding new logic in a `.js` source file. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The file is a modified JavaScript source file (`.js`), and the rule
explicitly says frontend code should be converted to TypeScript rather than
added or modified as `.js`/`.jsx`. This is a real rule violation in the current
file.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=62ea6a9c028d41a29fd098f4248abf82&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=62ea6a9c028d41a29fd098f4248abf82&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-embedded-sdk/release-if-necessary.js
**Line:** 20:20
**Comment:**
*Custom Rule: Convert this release script to TypeScript and move it to
a `.ts` file instead of adding new logic in a `.js` source file.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38308&comment_hash=d0cf27e1504df084394e5d3fe45f59c79df1004c6e0ca95177f007fe57291e64&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F38308&comment_hash=d0cf27e1504df084394e5d3fe45f59c79df1004c6e0ca95177f007fe57291e64&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
