rusackas commented on code in PR #41129:
URL: https://github.com/apache/superset/pull/41129#discussion_r3487359279
##########
superset-frontend/src/features/home/RightMenu.tsx:
##########
@@ -781,6 +782,7 @@ const RightMenu = ({
// segments in the Scarf pixel URL.
sha={navbarRight.version_sha || undefined}
build={navbarRight.build_number || undefined}
+ enabled={SCARF_ANALYTICS !== false}
Review Comment:
The opt-out logic is already covered in `TelemetryPixel.test.tsx` via the
`enabled` prop true/false cases. `RightMenu` just forwards `SCARF_ANALYTICS !==
false`, so a test there would only re-assert prop wiring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
