bito-code-review[bot] commented on code in PR #41129:
URL: https://github.com/apache/superset/pull/41129#discussion_r3487359399
##########
superset-frontend/src/features/home/RightMenu.tsx:
##########
@@ -781,6 +782,7 @@ const RightMenu = ({
// segments in the Scarf pixel URL.
sha={navbarRight.version_sha || undefined}
build={navbarRight.build_number || undefined}
+ enabled={SCARF_ANALYTICS !== false}
Review Comment:
<!-- Bito Reply -->
The suggestion to add tests in `RightMenu.test.tsx` is appropriate. While
the opt-out logic is tested in `TelemetryPixel.test.tsx`, adding a test in
`RightMenu.test.tsx` ensures that the `enabled` prop is correctly wired and
passed to the `TelemetryPixel` component based on the `SCARF_ANALYTICS`
constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
