codeant-ai-for-open-source[bot] commented on code in PR #40129: URL: https://github.com/apache/superset/pull/40129#discussion_r3492943034
########## superset/commands/chart/restore.py: ########## @@ -0,0 +1,39 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Command to restore a soft-deleted chart.""" + +from superset.commands.chart.exceptions import ( + ChartForbiddenError, + ChartNotFoundError, + ChartRestoreFailedError, +) +from superset.commands.restore import BaseRestoreCommand +from superset.daos.chart import ChartDAO +from superset.models.slice import Slice + + +class RestoreChartCommand(BaseRestoreCommand[Slice]): + """Restore a soft-deleted chart by clearing its ``deleted_at`` field. + + All transactional wrapping and validation lives in + ``BaseRestoreCommand``; this subclass is purely declarative. + """ + + dao = ChartDAO + not_found_exc = ChartNotFoundError + forbidden_exc = ChartForbiddenError + restore_failed_exc = ChartRestoreFailedError Review Comment: **Suggestion:** Add explicit type annotations to the declarative class attributes so these bindings are type-hinted rather than untyped assignments. [custom_rule] **Severity Level:** Minor ⚠️ <details> <summary><b>Why it matters? 🤔 </b></summary> These new class attributes are typed bindings that can be annotated, but the file assigns them without any type hints. That matches the custom rule requiring type hints on relevant variables in modified Python code. </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=5b3282dc14864ee7af5eb1ad2d120698&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=5b3282dc14864ee7af5eb1ad2d120698&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/commands/chart/restore.py **Line:** 36:39 **Comment:** *Custom Rule: Add explicit type annotations to the declarative class attributes so these bindings are type-hinted rather than untyped assignments. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40129&comment_hash=5c50a1691b2ac2b7306e7cae8431ae62d01f30029dd3ffc6c4e6a5857cc4d1fb&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40129&comment_hash=5c50a1691b2ac2b7306e7cae8431ae62d01f30029dd3ffc6c4e6a5857cc4d1fb&reaction=dislike'>👎</a> ########## superset/daos/dashboard.py: ########## @@ -276,8 +277,19 @@ def set_dash_metadata( if isinstance(value, dict) ] + # Bypass the soft-delete visibility filter when resolving the + # incoming chart ids: a dashboard's ``position_json`` may still + # reference a chart that is currently soft-deleted, and this + # assignment REBUILDS ``dashboard.slices`` wholesale. With the + # filter active, the hidden member would be silently dropped — + # deleting its ``dashboard_slices`` junction row (breaking the + # documented restore-reattach contract) and writing + # ``uuid: None`` into its position slot via ``uuid_map`` below. current_slices = ( - db.session.query(Slice).filter(Slice.id.in_(slice_ids)).all() + db.session.query(Slice) + .execution_options(**{SKIP_VISIBILITY_FILTER_CLASSES: {Slice}}) + .filter(Slice.id.in_(slice_ids)) + .all() ) Review Comment: **Suggestion:** Add an explicit type annotation for the newly introduced local variable so the modified Python code complies with the type-hint requirement. [custom_rule] **Severity Level:** Minor ⚠️ <details> <summary><b>Why it matters? 🤔 </b></summary> This modified Python code introduces a new local variable without a type annotation. Since `current_slices` is clearly a list of `Slice` objects and can be annotated, it matches the type-hint requirement rule. </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=ef35084360cc4b3a9ca7ef8948631e7c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=ef35084360cc4b3a9ca7ef8948631e7c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/daos/dashboard.py **Line:** 288:293 **Comment:** *Custom Rule: Add an explicit type annotation for the newly introduced local variable so the modified Python code complies with the type-hint requirement. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40129&comment_hash=ffb0e815cbbafb6e7501c8d3ae9973a05af911313cc1c62b3ed4b6338f224dcf&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40129&comment_hash=ffb0e815cbbafb6e7501c8d3ae9973a05af911313cc1c62b3ed4b6338f224dcf&reaction=dislike'>👎</a> ########## tests/integration_tests/charts/commands_tests.py: ########## @@ -721,7 +721,7 @@ def test_fave_unfave_chart_command(self): def test_fave_unfave_chart_command_not_found(self): """Test that faving / unfaving a non-existing chart raises an exception""" with self.client.application.test_request_context(): - example_chart_id = 1234 + example_chart_id = 0 Review Comment: **Suggestion:** Add an explicit type annotation to this newly introduced local variable. [custom_rule] **Severity Level:** Minor ⚠️ <details> <summary><b>Why it matters? 🤔 </b></summary> The new local variable is a simple Python assignment in modified code and can be annotated with a type hint such as `example_chart_id: int = 0`, so it matches the rule requiring type hints for relevant variables that can be annotated. </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=97a03e8d923247bcb2922aa287d100a6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=97a03e8d923247bcb2922aa287d100a6&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** tests/integration_tests/charts/commands_tests.py **Line:** 724:724 **Comment:** *Custom Rule: Add an explicit type annotation to this newly introduced local variable. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40129&comment_hash=7d4e54840d1cec33b05413462cbe6e98d5f7fbc2f4c482dc10d274952dbaf3b8&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40129&comment_hash=7d4e54840d1cec33b05413462cbe6e98d5f7fbc2f4c482dc10d274952dbaf3b8&reaction=dislike'>👎</a> ########## tests/unit_tests/commands/chart/restore_test.py: ########## @@ -0,0 +1,90 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Unit tests for RestoreChartCommand.""" + +from __future__ import annotations + +from datetime import datetime, timezone +from unittest.mock import MagicMock, patch + +import pytest + +from superset.commands.chart.exceptions import ( + ChartForbiddenError, + ChartNotFoundError, +) +from superset.commands.chart.restore import RestoreChartCommand +from superset.exceptions import SupersetSecurityException + + +def test_restore_chart_clears_deleted_at(app_context: None) -> None: + """RestoreChartCommand.run() restores a soft-deleted chart.""" + chart = MagicMock() Review Comment: **Suggestion:** Add an explicit type annotation for this test-local mock variable to satisfy the type-hint requirement. [custom_rule] **Severity Level:** Minor ⚠️ <details> <summary><b>Why it matters? 🤔 </b></summary> This new test-local variable is introduced without an explicit type hint, and it is a relevant variable that could be annotated under the Python type-hint rule. </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=ade5d379185a4b65bbc86383abce2308&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=ade5d379185a4b65bbc86383abce2308&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** tests/unit_tests/commands/chart/restore_test.py **Line:** 36:36 **Comment:** *Custom Rule: Add an explicit type annotation for this test-local mock variable to satisfy the type-hint requirement. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40129&comment_hash=49450f6e2ee99107e8501138be6406afd489be0803eca5f788a915c5a64c50a8&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40129&comment_hash=49450f6e2ee99107e8501138be6406afd489be0803eca5f788a915c5a64c50a8&reaction=dislike'>👎</a> ########## tests/unit_tests/commands/chart/restore_test.py: ########## @@ -0,0 +1,90 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Unit tests for RestoreChartCommand.""" + +from __future__ import annotations + +from datetime import datetime, timezone +from unittest.mock import MagicMock, patch + +import pytest + +from superset.commands.chart.exceptions import ( + ChartForbiddenError, + ChartNotFoundError, +) +from superset.commands.chart.restore import RestoreChartCommand +from superset.exceptions import SupersetSecurityException + + +def test_restore_chart_clears_deleted_at(app_context: None) -> None: + """RestoreChartCommand.run() restores a soft-deleted chart.""" + chart = MagicMock() + chart.deleted_at = datetime(2026, 1, 1, tzinfo=timezone.utc) + chart.id = 1 + + with ( + patch( + "superset.daos.chart.ChartDAO.find_by_id", return_value=chart + ) as mock_find, + patch("superset.commands.restore.security_manager") as mock_sec, + ): + mock_sec.raise_for_ownership.return_value = None + + cmd = RestoreChartCommand("1") + cmd.run() + + mock_find.assert_called_once() + chart.restore.assert_called_once() + + +def test_restore_chart_not_found_raises(app_context: None) -> None: + """RestoreChartCommand raises ChartNotFoundError for missing chart.""" + with patch("superset.daos.chart.ChartDAO.find_by_id", return_value=None): + cmd = RestoreChartCommand("999") Review Comment: **Suggestion:** Add a type annotation for this command instance variable so the new code consistently uses typed local variables. [custom_rule] **Severity Level:** Minor ⚠️ <details> <summary><b>Why it matters? 🤔 </b></summary> This new local variable is assigned a command instance without a type hint, which matches the type-hint rule for annotatable variables. </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=f5c8bce9791e4f708463d295db929506&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=f5c8bce9791e4f708463d295db929506&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** tests/unit_tests/commands/chart/restore_test.py **Line:** 58:58 **Comment:** *Custom Rule: Add a type annotation for this command instance variable so the new code consistently uses typed local variables. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40129&comment_hash=00f3378988f62e82deb908266b860271d9ded55f7967fcd39b089127a84ddec8&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40129&comment_hash=00f3378988f62e82deb908266b860271d9ded55f7967fcd39b089127a84ddec8&reaction=dislike'>👎</a> ########## tests/unit_tests/migrations/test_add_deleted_at_to_slices.py: ########## @@ -0,0 +1,186 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Tests for migration ``7c4a8d09ca37_add_deleted_at_to_slices``. + +Runs the migration's ``upgrade()`` and ``downgrade()`` against an +in-memory SQLite engine with a real Alembic ``Operations`` context. +The behaviour being pinned is the operator-facing contract documented +in ``UPDATING.md``: ``downgrade()`` reverses the schema but does not +hard-delete or otherwise mutate rows that were soft-deleted before +the migration was reversed — those rows survive the downgrade and +become visible to any code path that no longer applies the +soft-delete visibility filter. +""" + +from __future__ import annotations + +from datetime import datetime +from importlib import import_module + +import pytest +from alembic.migration import MigrationContext +from alembic.operations import Operations +from sqlalchemy import ( + Column, + create_engine, + insert, + inspect, + Integer, + MetaData, + select, + String, + Table, +) +from sqlalchemy.engine import Engine + +migration = import_module( + "superset.migrations.versions." + "2026-05-08_12-00_7c4a8d09ca37_add_deleted_at_to_slices" +) + +TABLE_NAME = migration.TABLE_NAME # "slices" +INDEX_NAME = migration.INDEX_NAME # "ix_slices_deleted_at" Review Comment: **Suggestion:** Add explicit type annotations for these module-level constants so they comply with the required Python typing rule. [custom_rule] **Severity Level:** Minor ⚠️ <details> <summary><b>Why it matters? 🤔 </b></summary> These module-level constants are new Python variables that can be annotated, and they currently lack type hints. That matches the typing rule requiring type hints on relevant variables in new or modified Python code. </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=5f2656aaf141499a8e8b19d6f2fbcd1a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=5f2656aaf141499a8e8b19d6f2fbcd1a&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** tests/unit_tests/migrations/test_add_deleted_at_to_slices.py **Line:** 55:56 **Comment:** *Custom Rule: Add explicit type annotations for these module-level constants so they comply with the required Python typing rule. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40129&comment_hash=5b8f13f777061d495d9cbe2909f9893159d181f0bd11d0c6b880f0e6641fc7fa&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40129&comment_hash=5b8f13f777061d495d9cbe2909f9893159d181f0bd11d0c6b880f0e6641fc7fa&reaction=dislike'>👎</a> ########## tests/unit_tests/commands/chart/restore_test.py: ########## @@ -0,0 +1,90 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""Unit tests for RestoreChartCommand.""" + +from __future__ import annotations + +from datetime import datetime, timezone +from unittest.mock import MagicMock, patch + +import pytest + +from superset.commands.chart.exceptions import ( + ChartForbiddenError, + ChartNotFoundError, +) +from superset.commands.chart.restore import RestoreChartCommand +from superset.exceptions import SupersetSecurityException + + +def test_restore_chart_clears_deleted_at(app_context: None) -> None: + """RestoreChartCommand.run() restores a soft-deleted chart.""" + chart = MagicMock() + chart.deleted_at = datetime(2026, 1, 1, tzinfo=timezone.utc) + chart.id = 1 + + with ( + patch( + "superset.daos.chart.ChartDAO.find_by_id", return_value=chart + ) as mock_find, + patch("superset.commands.restore.security_manager") as mock_sec, + ): + mock_sec.raise_for_ownership.return_value = None + + cmd = RestoreChartCommand("1") + cmd.run() + + mock_find.assert_called_once() + chart.restore.assert_called_once() + + +def test_restore_chart_not_found_raises(app_context: None) -> None: + """RestoreChartCommand raises ChartNotFoundError for missing chart.""" + with patch("superset.daos.chart.ChartDAO.find_by_id", return_value=None): + cmd = RestoreChartCommand("999") + with pytest.raises(ChartNotFoundError): + cmd.run() + + +def test_restore_active_chart_raises_not_found(app_context: None) -> None: + """RestoreChartCommand raises ChartNotFoundError for non-deleted chart.""" + chart = MagicMock() Review Comment: **Suggestion:** Add an explicit type annotation for this mock object variable in the test to comply with the type-hints rule. [custom_rule] **Severity Level:** Minor ⚠️ <details> <summary><b>Why it matters? 🤔 </b></summary> This is another new mock variable introduced without a type annotation, so it fits the stated Python type-hint violation. </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=7a954a470c60481a83a65387b3584412&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=7a954a470c60481a83a65387b3584412&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** tests/unit_tests/commands/chart/restore_test.py **Line:** 65:65 **Comment:** *Custom Rule: Add an explicit type annotation for this mock object variable in the test to comply with the type-hints rule. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40129&comment_hash=bb3377b66370a73a4bc735a5c40db64a04cc351d1bdf0291863786a292d13203&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40129&comment_hash=bb3377b66370a73a4bc735a5c40db64a04cc351d1bdf0291863786a292d13203&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
