mikebridge commented on PR #40129: URL: https://github.com/apache/superset/pull/40129#issuecomment-4836947265
### Soft-delete rollout — related PRs & merge order This is one of four coordinated PRs implementing soft-delete + restore per [SIP-208](https://github.com/apache/superset/issues/39464), on top of the merged infrastructure (#39977). **Merge order matters** — the gate must land first so the entity PRs ship behind the `SOFT_DELETE` release toggle (default **off**). Merging an entity PR before the gate would ship soft-delete **unguarded**. | Order | PR | Role | |-------|-----|------| | 1️⃣ | #41166 | `SOFT_DELETE` release toggle (the gate) — **merge first** | | 2️⃣ | #40129 | charts soft-delete + restore ⬅︎ | | 3️⃣ | #40128 | dashboards soft-delete + restore | | 4️⃣ | #40130 | datasets soft-delete + restore | After the gate merges, each entity PR is rebased onto the gated `master` and inherits the flag. Each entity migration's `down_revision` is currently `78a40c08b4be` (current master head) and is re-pointed at merge time as siblings land, to keep a single Alembic head. Charts entity PR ← **this PR** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
