codeant-ai-for-open-source[bot] commented on code in PR #41428:
URL: https://github.com/apache/superset/pull/41428#discussion_r3497277663
##########
tests/unit_tests/utils/webdriver_test.py:
##########
@@ -974,3 +974,72 @@ def evaluate_side_effect(script):
"not falling back to avoid sending a blank PDF",
"http://example.com";,
)
+
+ @patch("superset.utils.webdriver.PLAYWRIGHT_AVAILABLE", True)
+ @patch("superset.utils.webdriver._browser_manager")
+ @patch("superset.utils.webdriver.app")
+ def test_animation_wait_runs_after_spinners_clear(
+ self, mock_app, mock_browser_manager
+ ):
Review Comment:
**Suggestion:** Add explicit type hints to this newly added test method’s
parameters and return type. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The added test method is Python code and omits type hints for its parameters
and return type, which violates the rule requiring type hints on new or
modified Python functions and methods when they can be annotated.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=03157db380cd4661bc72939e21e49155&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=03157db380cd4661bc72939e21e49155&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/utils/webdriver_test.py
**Line:** 981:983
**Comment:**
*Custom Rule: Add explicit type hints to this newly added test method’s
parameters and return type.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41428&comment_hash=2df3472bb428f4a8b59ee456c888de4a45bbe2bc5c6dc281ef5cb8edddae826e&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41428&comment_hash=2df3472bb428f4a8b59ee456c888de4a45bbe2bc5c6dc281ef5cb8edddae826e&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
