codeant-ai-for-open-source[bot] commented on code in PR #41176:
URL: https://github.com/apache/superset/pull/41176#discussion_r3500127324
##########
superset/commands/importers/v1/utils.py:
##########
@@ -378,6 +378,7 @@ def safe_insert_dashboard_chart_relationships(
# Insert new relationships in bulk, deduplicating to avoid unique
constraint issues
if unique_new_relationships := set(new_relationships):
Review Comment:
**Suggestion:** Introduce an explicitly typed local variable for the
deduplicated relationships instead of creating it inline without an annotation.
[custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The rule requires type hints on newly introduced Python variables when they
can be annotated. This walrus assignment creates a new local variable without
an annotation, so the suggestion identifies a real typing omission.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=9eedfc5deb424a12b210a187f9fcf209&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=9eedfc5deb424a12b210a187f9fcf209&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/importers/v1/utils.py
**Line:** 380:380
**Comment:**
*Custom Rule: Introduce an explicitly typed local variable for the
deduplicated relationships instead of creating it inline without an annotation.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41176&comment_hash=2d28211dea1782b943c02bf1af1700d835bc78fdc951b8b6ceb2e5c5ba4e8604&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41176&comment_hash=2d28211dea1782b943c02bf1af1700d835bc78fdc951b8b6ceb2e5c5ba4e8604&reaction=dislike'>👎</a>
##########
superset/commands/importers/v1/utils.py:
##########
@@ -387,6 +388,37 @@ def safe_insert_dashboard_chart_relationships(
)
+def _prime_versioning_unit_of_work() -> None:
+ """Ensure Continuum has a unit-of-work for the current connection.
+
+ ``dashboard_slices`` is a Continuum-tracked (versioned) association
+ table, so a raw Core INSERT/DELETE on it fires Continuum's engine-level
+ ``before_execute`` listener, which looks up a unit-of-work for the
+ connection and raises ``KeyError`` when none is registered (the same
+ failure class the dashboard test factory hit). The normal import flow
+ registers one via prior ORM flushes, so this is belt-and-suspenders for
+ a bulk relationship insert that might run before any flush on the
+ connection. No-op (the listener is detached) when version capture is
+ disabled, which is the shipped default; never allowed to break an import.
+ """
+ try:
+ # pylint: disable=import-outside-toplevel
+ from sqlalchemy_continuum import versioning_manager
+
+ # Mirror the exact condition Continuum's track_association_operations
+ # listener uses to decide whether it acts (versioning OR
+ # native_versioning), so the prime can't skip while the listener runs.
+ options = versioning_manager.options
Review Comment:
**Suggestion:** Add an explicit type annotation to this local options
mapping to comply with the type-hint requirement for newly introduced
variables. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is a newly introduced local variable in modified Python code and it is
unannotated even though it can be typed, which matches the type-hint rule.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=d9eb59f2c2dc4972a76f503d24ccafc5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=d9eb59f2c2dc4972a76f503d24ccafc5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/commands/importers/v1/utils.py
**Line:** 411:411
**Comment:**
*Custom Rule: Add an explicit type annotation to this local options
mapping to comply with the type-hint requirement for newly introduced variables.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41176&comment_hash=1ac0e75197931bcc3de390b3d5e65a51733797cbaff3025e9f57d6b3dc4ca104&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41176&comment_hash=1ac0e75197931bcc3de390b3d5e65a51733797cbaff3025e9f57d6b3dc4ca104&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
