codeant-ai-for-open-source[bot] commented on code in PR #40905:
URL: https://github.com/apache/superset/pull/40905#discussion_r3500476133
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/getControlItemsMap.test.tsx:
##########
@@ -249,3 +321,77 @@ describe('ColumnSelect filterValues behavior', () => {
expect(screen.queryByText('col2')).not.toBeInTheDocument();
});
});
+
+// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from
describe blocks
+describe('plugin column-picker control (isColumnSelect)', () => {
Review Comment:
**Suggestion:** Refactor this newly introduced grouped block into standalone
`test()` cases (or a helper plus individual tests) to avoid introducing a new
`describe()` wrapper. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is newly added component test code in a test file, and it introduces a
`describe()` wrapper. The custom rule explicitly says new component test code
should use `test()` instead of `describe()` when a test case would suffice, so
the violation is real.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=0f15ec6900c944c8b83bd0bcb84838dc&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=0f15ec6900c944c8b83bd0bcb84838dc&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/getControlItemsMap.test.tsx
**Line:** 326:326
**Comment:**
*Custom Rule: Refactor this newly introduced grouped block into
standalone `test()` cases (or a helper plus individual tests) to avoid
introducing a new `describe()` wrapper.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40905&comment_hash=51d30afffa883deacf6d4f619b2b676a23eaacbd97477f7d248e8e2774d40da8&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40905&comment_hash=51d30afffa883deacf6d4f619b2b676a23eaacbd97477f7d248e8e2774d40da8&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
