YinkaMetrics opened a new pull request, #41617:
URL: https://github.com/apache/superset/pull/41617

   ### SUMMARY
   Fixes #40407.
   
   `TableSelector` now uses the existing `hasMore` value returned by 
`useTables` to show a helper message when the API reports more tables than were 
returned in the current response. This makes truncated table lists visible to 
users and prompts them to refine their search.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Not included. The UI change is a small helper message below the table 
selector:
   
   `Some tables are not shown. Refine your search.`
   
   ### TESTING INSTRUCTIONS
   - `cd superset-frontend`
   - `npm run test -- src/components/TableSelector/TableSelector.test.tsx`
   - `npx prettier --check src/components/TableSelector/index.tsx 
src/components/TableSelector/TableSelector.test.tsx`
   - `npx oxlint --config oxlint.json --quiet 
src/components/TableSelector/index.tsx 
src/components/TableSelector/TableSelector.test.tsx`
   - `npm run plugins:build`
   - `npm run type`
   - `prek run --all-files`
   
   Note: `prek run --all-files` passed the frontend hooks relevant to this 
change, including `prettier (frontend)`, `oxlint (frontend)`, `custom rules 
(frontend)`, and `Type-Checking (Frontend)`. The repo-wide run still failed on 
unrelated existing/local-environment items: mypy errors in 
`tests/unit_tests/semantic_layers/mapper_test.py`, missing `yarn` for docs 
eslint, missing `helm-docs`, existing Python ruff findings, and local `python` 
command resolution for two Python hooks.
   
   ### ADDITIONAL INFORMATION
   - [x] Has associated issue: Fixes #40407
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to