bito-code-review[bot] commented on code in PR #41636:
URL: https://github.com/apache/superset/pull/41636#discussion_r3508626032
##########
superset-frontend/packages/superset-ui-core/src/components/Tabs/Tabs.test.tsx:
##########
@@ -48,7 +48,7 @@ describe('Tabs', () => {
expect(getByText('Tab 3')).toBeInTheDocument();
const activeTabContent = container.querySelector(
- '.ant-tabs-tabpane-active',
+ '.ant-tabs-content-active',
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incomplete refactoring - test/component mismatch</b></div>
<div id="fix">
The tests query for CSS classes (`.ant-tabs-body-holder`, `.ant-tabs-body`,
`.ant-tabs-content`) that do not exist in the `StyledTabs` component's CSS
template at `Tabs.tsx:51-64`. The component still uses the old class names
(`.ant-tabs-content-holder`, `.ant-tabs-content`, `.ant-tabs-tabpane`). This
mismatch causes all `fullHeight` tests and related assertions to fail at
runtime because `querySelector` returns `null` for non-existent classes.
</div>
</div>
<small><i>Code Review Run #8eacea</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
