codeant-ai-for-open-source[bot] commented on code in PR #41636:
URL: https://github.com/apache/superset/pull/41636#discussion_r3509861993
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/utils.ts:
##########
@@ -471,7 +471,7 @@ export function applyAdvancedTimeRangeFilterOnDashboard(
endRange?: string,
) {
cy.get('.control-label').contains('Range type').should('be.visible');
- cy.get('.ant-popover-content .ant-select-selector')
+ cy.get('.ant-popover-content .ant-select-content')
.should('be.visible')
.click();
Review Comment:
**Suggestion:** Replace this Cypress selector interaction with the
equivalent Playwright locator/action in the end-to-end helper. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The changed end-to-end helper is still using Cypress (`cy.get(...)`) in a
newly modified test path, which matches the rule requiring Playwright instead
of Cypress.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=61f3399c66e346b18e2c290d0ac5fbb4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=61f3399c66e346b18e2c290d0ac5fbb4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/cypress-base/cypress/e2e/dashboard/utils.ts
**Line:** 474:476
**Comment:**
*Custom Rule: Replace this Cypress selector interaction with the
equivalent Playwright locator/action in the end-to-end helper.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=b54075d7b134f96b4e004801b6d9a3a19d2e3e125a78ba9032538b8ea59b0fc6&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=b54075d7b134f96b4e004801b6d9a3a19d2e3e125a78ba9032538b8ea59b0fc6&reaction=dislike'>👎</a>
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/utils.ts:
##########
@@ -514,15 +514,14 @@ export function inputNativeFilterDefaultValue(
)
.eq(1)
.within(() => {
- cy.get('.ant-select-selection-search-input').type(
- `${defaultValue}{enter}`,
- { force: true },
- );
+ cy.get('.ant-select-input').type(`${defaultValue}{enter}`, {
+ force: true,
+ });
Review Comment:
**Suggestion:** Migrate this newly added Cypress input typing step to a
Playwright-based interaction. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This newly added input interaction uses Cypress `cy.get(...).type(...)`
inside an updated E2E helper, so it violates the rule preferring Playwright
over Cypress.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=f7e51b5db1ae4d06ac48a00113bc6e89&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=f7e51b5db1ae4d06ac48a00113bc6e89&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/cypress-base/cypress/e2e/dashboard/utils.ts
**Line:** 517:519
**Comment:**
*Custom Rule: Migrate this newly added Cypress input typing step to a
Playwright-based interaction.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=6983d66c4bfbdfe282eae9fad41907af606fba21ebc7e3ef690c407c5cd62cb2&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=6983d66c4bfbdfe282eae9fad41907af606fba21ebc7e3ef690c407c5cd62cb2&reaction=dislike'>👎</a>
##########
superset-frontend/cypress-base/cypress/e2e/explore/utils.ts:
##########
@@ -53,9 +53,7 @@ export function saveChartToDashboard(chartName: string,
dashboardName: string) {
.then($modal => {
cy.wait(500);
cy.wrap($modal)
- .find(
- '.ant-select-selection-search-input[aria-label*="Select a
dashboard"]',
- )
+ .find('.ant-select-input[aria-label*="Select a dashboard"]')
Review Comment:
**Suggestion:** Migrate this updated end-to-end interaction from Cypress to
an equivalent Playwright step instead of adding new Cypress-based test logic.
[custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The changed file is an end-to-end Cypress test utility and the updated line
continues to use Cypress-specific chaining to interact with the UI. This
matches the rule forbidding new or changed e2e test code that uses Cypress
instead of Playwright.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b8324ceaef824d5ea5303b318e8fa372&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b8324ceaef824d5ea5303b318e8fa372&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/cypress-base/cypress/e2e/explore/utils.ts
**Line:** 56:56
**Comment:**
*Custom Rule: Migrate this updated end-to-end interaction from Cypress
to an equivalent Playwright step instead of adding new Cypress-based test logic.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=143c58b487c478b57935850324e2562175fea548a3ad528742fe753bc3ed7325&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=143c58b487c478b57935850324e2562175fea548a3ad528742fe753bc3ed7325&reaction=dislike'>👎</a>
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/utils.ts:
##########
@@ -514,15 +514,14 @@ export function inputNativeFilterDefaultValue(
)
.eq(1)
.within(() => {
- cy.get('.ant-select-selection-search-input').type(
- `${defaultValue}{enter}`,
- { force: true },
- );
+ cy.get('.ant-select-input').type(`${defaultValue}{enter}`, {
+ force: true,
+ });
Review Comment:
**Suggestion:** Migrate this newly added Cypress input typing step to a
Playwright-based interaction. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This newly added input interaction uses Cypress `cy.get(...).type(...)`
inside an updated E2E helper, so it violates the rule preferring Playwright
over Cypress.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=f7e51b5db1ae4d06ac48a00113bc6e89&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=f7e51b5db1ae4d06ac48a00113bc6e89&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/cypress-base/cypress/e2e/dashboard/utils.ts
**Line:** 517:519
**Comment:**
*Custom Rule: Migrate this newly added Cypress input typing step to a
Playwright-based interaction.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=6983d66c4bfbdfe282eae9fad41907af606fba21ebc7e3ef690c407c5cd62cb2&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=6983d66c4bfbdfe282eae9fad41907af606fba21ebc7e3ef690c407c5cd62cb2&reaction=dislike'>👎</a>
##########
superset-frontend/cypress-base/cypress/e2e/explore/utils.ts:
##########
@@ -53,9 +53,7 @@ export function saveChartToDashboard(chartName: string,
dashboardName: string) {
.then($modal => {
cy.wait(500);
cy.wrap($modal)
- .find(
- '.ant-select-selection-search-input[aria-label*="Select a
dashboard"]',
- )
+ .find('.ant-select-input[aria-label*="Select a dashboard"]')
Review Comment:
**Suggestion:** Migrate this updated end-to-end interaction from Cypress to
an equivalent Playwright step instead of adding new Cypress-based test logic.
[custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The changed file is an end-to-end Cypress test utility and the updated line
continues to use Cypress-specific chaining to interact with the UI. This
matches the rule forbidding new or changed e2e test code that uses Cypress
instead of Playwright.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b8324ceaef824d5ea5303b318e8fa372&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b8324ceaef824d5ea5303b318e8fa372&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/cypress-base/cypress/e2e/explore/utils.ts
**Line:** 56:56
**Comment:**
*Custom Rule: Migrate this updated end-to-end interaction from Cypress
to an equivalent Playwright step instead of adding new Cypress-based test logic.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=143c58b487c478b57935850324e2562175fea548a3ad528742fe753bc3ed7325&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=143c58b487c478b57935850324e2562175fea548a3ad528742fe753bc3ed7325&reaction=dislike'>👎</a>
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/utils.ts:
##########
@@ -514,15 +514,14 @@ export function inputNativeFilterDefaultValue(
)
.eq(1)
.within(() => {
- cy.get('.ant-select-selection-search-input').type(
- `${defaultValue}{enter}`,
- { force: true },
- );
+ cy.get('.ant-select-input').type(`${defaultValue}{enter}`, {
+ force: true,
+ });
});
});
} else {
cy.getBySel('default-input').within(() => {
- cy.get('.ant-select-selection-search-input').click();
+ cy.get('.ant-select-input').click();
Review Comment:
**Suggestion:** Convert this added Cypress click call to the corresponding
Playwright click action. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The modified helper introduces another Cypress command in end-to-end test
code, which is exactly what the Playwright-over-Cypress rule forbids.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=6e74996c0ebc41f9b0db28f8acc89ec3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=6e74996c0ebc41f9b0db28f8acc89ec3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/cypress-base/cypress/e2e/dashboard/utils.ts
**Line:** 524:524
**Comment:**
*Custom Rule: Convert this added Cypress click call to the
corresponding Playwright click action.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=b0e88a6641bcca58ae3924254f811af860c3b224d91dd263203236d11b4c61c9&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=b0e88a6641bcca58ae3924254f811af860c3b224d91dd263203236d11b4c61c9&reaction=dislike'>👎</a>
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/utils.ts:
##########
@@ -514,15 +514,14 @@ export function inputNativeFilterDefaultValue(
)
.eq(1)
.within(() => {
- cy.get('.ant-select-selection-search-input').type(
- `${defaultValue}{enter}`,
- { force: true },
- );
+ cy.get('.ant-select-input').type(`${defaultValue}{enter}`, {
+ force: true,
+ });
});
});
} else {
cy.getBySel('default-input').within(() => {
- cy.get('.ant-select-selection-search-input').click();
+ cy.get('.ant-select-input').click();
Review Comment:
**Suggestion:** Convert this added Cypress click call to the corresponding
Playwright click action. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The modified helper introduces another Cypress command in end-to-end test
code, which is exactly what the Playwright-over-Cypress rule forbids.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=6e74996c0ebc41f9b0db28f8acc89ec3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=6e74996c0ebc41f9b0db28f8acc89ec3&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/cypress-base/cypress/e2e/dashboard/utils.ts
**Line:** 524:524
**Comment:**
*Custom Rule: Convert this added Cypress click call to the
corresponding Playwright click action.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=b0e88a6641bcca58ae3924254f811af860c3b224d91dd263203236d11b4c61c9&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=b0e88a6641bcca58ae3924254f811af860c3b224d91dd263203236d11b4c61c9&reaction=dislike'>👎</a>
##########
superset-frontend/cypress-base/cypress/support/directories.ts:
##########
@@ -91,7 +91,7 @@ export const databasesPage = {
preferredBlockSheets: '.preferred > :nth-child(6)',
supportedDatabasesText: '.control-label',
orChoose: '.available-label',
- dbDropdown: '[class="ant-select-selection-search-input"]',
+ dbDropdown: '.ant-select-input',
Review Comment:
**Suggestion:** Do not add new end-to-end test support selectors under the
Cypress test suite; migrate this new test locator coverage to the
Playwright-based test infrastructure instead. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The changed line adds new Cypress test support selectors inside the
Cypress-based end-to-end test suite. The custom rule explicitly requires new or
changed E2E test code to use Playwright instead of Cypress, so this is a real
rule violation.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=65349b13a4f349579d2a72c49b5ff793&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=65349b13a4f349579d2a72c49b5ff793&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/cypress-base/cypress/support/directories.ts
**Line:** 94:94
**Comment:**
*Custom Rule: Do not add new end-to-end test support selectors under
the Cypress test suite; migrate this new test locator coverage to the
Playwright-based test infrastructure instead.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=37cfe8e1f4ddcba0272c25bb1dadcdda34ee75ffbbf9c01ef521ed9aa8abe762&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=37cfe8e1f4ddcba0272c25bb1dadcdda34ee75ffbbf9c01ef521ed9aa8abe762&reaction=dislike'>👎</a>
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/utils.ts:
##########
@@ -471,7 +471,7 @@ export function applyAdvancedTimeRangeFilterOnDashboard(
endRange?: string,
) {
cy.get('.control-label').contains('Range type').should('be.visible');
- cy.get('.ant-popover-content .ant-select-selector')
+ cy.get('.ant-popover-content .ant-select-content')
.should('be.visible')
.click();
Review Comment:
**Suggestion:** Replace this Cypress selector interaction with the
equivalent Playwright locator/action in the end-to-end helper. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The changed end-to-end helper is still using Cypress (`cy.get(...)`) in a
newly modified test path, which matches the rule requiring Playwright instead
of Cypress.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=61f3399c66e346b18e2c290d0ac5fbb4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=61f3399c66e346b18e2c290d0ac5fbb4&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/cypress-base/cypress/e2e/dashboard/utils.ts
**Line:** 474:476
**Comment:**
*Custom Rule: Replace this Cypress selector interaction with the
equivalent Playwright locator/action in the end-to-end helper.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=b54075d7b134f96b4e004801b6d9a3a19d2e3e125a78ba9032538b8ea59b0fc6&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=b54075d7b134f96b4e004801b6d9a3a19d2e3e125a78ba9032538b8ea59b0fc6&reaction=dislike'>👎</a>
##########
superset-frontend/cypress-base/cypress/support/directories.ts:
##########
@@ -91,7 +91,7 @@ export const databasesPage = {
preferredBlockSheets: '.preferred > :nth-child(6)',
supportedDatabasesText: '.control-label',
orChoose: '.available-label',
- dbDropdown: '[class="ant-select-selection-search-input"]',
+ dbDropdown: '.ant-select-input',
Review Comment:
**Suggestion:** Do not add new end-to-end test support selectors under the
Cypress test suite; migrate this new test locator coverage to the
Playwright-based test infrastructure instead. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The changed line adds new Cypress test support selectors inside the
Cypress-based end-to-end test suite. The custom rule explicitly requires new or
changed E2E test code to use Playwright instead of Cypress, so this is a real
rule violation.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=65349b13a4f349579d2a72c49b5ff793&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=65349b13a4f349579d2a72c49b5ff793&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/cypress-base/cypress/support/directories.ts
**Line:** 94:94
**Comment:**
*Custom Rule: Do not add new end-to-end test support selectors under
the Cypress test suite; migrate this new test locator coverage to the
Playwright-based test infrastructure instead.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=37cfe8e1f4ddcba0272c25bb1dadcdda34ee75ffbbf9c01ef521ed9aa8abe762&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41636&comment_hash=37cfe8e1f4ddcba0272c25bb1dadcdda34ee75ffbbf9c01ef521ed9aa8abe762&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
