codeant-ai-for-open-source[bot] commented on code in PR #41653:
URL: https://github.com/apache/superset/pull/41653#discussion_r3509983620
##########
tests/unit_tests/dao/base_dao_test.py:
##########
@@ -309,3 +309,67 @@ def test_list_page_size_below_one_is_floored():
mock_query = _list_with_page_size(0)
mock_query.limit.assert_called_once_with(1)
+
+
+def test_like_operators_none_value_matches_no_rows() -> None:
+ """A ``None`` value on a LIKE-family operator must match no rows.
+
+ Mirrors SQL three-valued logic (``x LIKE NULL`` is NULL). The failure
+ modes this pins against: raising ``AttributeError`` (``None`` has no
+ ``.replace``) and, worse, coercing ``None`` to ``""`` — which builds a
+ wildcard-only pattern (``%%``/``%``) that silently matches every row.
+ """
+ Base_test = declarative_base() # noqa: N806
+
+ class NoneValueModel(Base_test): # type: ignore
+ __tablename__ = "none_value_model"
+ id = Column(Integer, primary_key=True)
+ name = Column(String(50))
+
+ like_family = [
+ ColumnOperatorEnum.sw,
+ ColumnOperatorEnum.ew,
+ ColumnOperatorEnum.ct,
+ ColumnOperatorEnum.like,
+ ColumnOperatorEnum.ilike,
+ ]
Review Comment:
**Suggestion:** Add an explicit type annotation for this new collection
variable to satisfy the type-hint requirement on annotatable variables.
[custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This new local variable is clearly annotatable, but it is introduced without
a type hint. That violates the rule requiring type hints on relevant variables
in modified Python code.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=9f64150d2cfe4b63acba31faf499e8d9&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=9f64150d2cfe4b63acba31faf499e8d9&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/dao/base_dao_test.py
**Line:** 329:335
**Comment:**
*Custom Rule: Add an explicit type annotation for this new collection
variable to satisfy the type-hint requirement on annotatable variables.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41653&comment_hash=2fd44f35a240e2184beddc4a215270a685033420a3e6fcb2c972f4b5435b91f7&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41653&comment_hash=2fd44f35a240e2184beddc4a215270a685033420a3e6fcb2c972f4b5435b91f7&reaction=dislike'>👎</a>
##########
tests/unit_tests/dao/base_dao_test.py:
##########
@@ -309,3 +309,67 @@ def test_list_page_size_below_one_is_floored():
mock_query = _list_with_page_size(0)
mock_query.limit.assert_called_once_with(1)
+
+
+def test_like_operators_none_value_matches_no_rows() -> None:
+ """A ``None`` value on a LIKE-family operator must match no rows.
+
+ Mirrors SQL three-valued logic (``x LIKE NULL`` is NULL). The failure
+ modes this pins against: raising ``AttributeError`` (``None`` has no
+ ``.replace``) and, worse, coercing ``None`` to ``""`` — which builds a
+ wildcard-only pattern (``%%``/``%``) that silently matches every row.
+ """
+ Base_test = declarative_base() # noqa: N806
+
+ class NoneValueModel(Base_test): # type: ignore
+ __tablename__ = "none_value_model"
+ id = Column(Integer, primary_key=True)
Review Comment:
**Suggestion:** Use a UUID-based primary key field for this new SQLAlchemy
model instead of an integer auto-increment primary key. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
This is a newly introduced SQLAlchemy model definition and it uses an
integer primary key. That matches the UUID-primary-key rule violation described
by the suggestion.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=93d60bff12194c6bb8892a097a4fa180&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=93d60bff12194c6bb8892a097a4fa180&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** tests/unit_tests/dao/base_dao_test.py
**Line:** 326:326
**Comment:**
*Custom Rule: Use a UUID-based primary key field for this new
SQLAlchemy model instead of an integer auto-increment primary key.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41653&comment_hash=2d31b194333d249e1d972466d4b7cebec694c26ca4a20e9f9ca7d06d37185e4b&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41653&comment_hash=2d31b194333d249e1d972466d4b7cebec694c26ca4a20e9f9ca7d06d37185e4b&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
