codeant-ai-for-open-source[bot] commented on code in PR #41657:
URL: https://github.com/apache/superset/pull/41657#discussion_r3510185040


##########
superset/translations/ca/LC_MESSAGES/messages.po:
##########
@@ -15012,35 +15884,62 @@ msgstr "La llista de valors del filtre no pot estar 
buida"
 msgid "This filter might be incompatible with current %s"
 msgstr "Aquest filtre pot ser incompatible amb el dataset actual"
 
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: cs, de, ja,
+# lv, ru, sk, sr, sr_Latn, tr, uk]
+#, fuzzy
 msgid "This folder is currently empty"
-msgstr ""
+msgstr "Aquesta carpeta està buida"
 
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: de, sr,
+# sr_Latn]
+#, fuzzy
 msgid "This folder only supports columns"
-msgstr ""
+msgstr "Aquesta carpeta només admet columnes"
 
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: de, sr,
+# sr_Latn]
+#, fuzzy
 msgid "This folder only supports metrics"
-msgstr ""
+msgstr "Aquesta carpeta només admet mètriques"
 
 msgid "This functionality is disabled in your environment for security 
reasons."
 msgstr ""
 "Aquesta funcionalitat està deshabilitada al teu entorn per raons de "
 "seguretat."
 
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: cs, de, ja,
+# lv, ru, sk, sr, sr_Latn, tr, uk]
+#, fuzzy
 msgid ""
 "This is a default columns folder. Its name cannot be changed or removed. "
 "It can stay empty but will only accept column items."
 msgstr ""
+"Aquesta és una carpeta de columnes predeterminada. El seu nom no es pot "
+"canviar ni eliminar. Pot quedar buida, però només acceptarà elements de "
+"columnes."
 
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: cs, de, ja,
+# lv, ru, sk, sr, sr_Latn, tr, uk]
+#, fuzzy
 msgid ""
 "This is a default metrics folder. Its name cannot be changed or removed. "
 "It can stay empty but will only accept metric items."
 msgstr ""
+"Aquesta és una carpeta de mètriques predeterminada. El seu nom no es pot "
+"canviar ni eliminar. Pot quedar buida, però només acceptarà elements de "
+"mètriques."
 
+# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: cs, de, ja,
+# lv, ro, ru, sk, sr, sr_Latn, tr, uk]
+#, fuzzy
 msgid "This is custom error message for a"
-msgstr ""
+msgstr "Aquest és un missatge d'error personalitzat per a a"

Review Comment:
   **Suggestion:** The translated string has an obvious duplicated token (`a 
a`), which will show a visibly incorrect message in the UI. Keep the final 
identifier as a single token (for example, quoted) so the sentence does not 
contain the duplicated `a`. [typo]
   
   <details>
   <summary><b>Severity Level:</b> Minor 🧹</summary>
   
   ```mdx
   - ⚠️ Custom DB error message in Catalan shows duplicated token.
   - ⚠️ Catalan UI wording appears less professional to end users.
   ```
   </details>
   <details>
   <summary><b>Steps of Reproduction ✅ </b></summary>
   
   ```mdx
   1. Start Superset with CUSTOM_DATABASE_ERRORS configured (default example 
config) in
   `superset/custom_database_errors.py:58-83`, which registers a handler for 
`re.compile("no
   such table: a")` returning `__("This is custom error message for a")`.
   
   2. Use a database named `"examples"` (matching the key in 
`CUSTOM_DATABASE_ERRORS` at
   `superset/custom_database_errors.py:61`) and execute a query that triggers 
the error `"no
   such table: a"` (for example `SELECT * FROM a` via SQL Lab or a chart).
   
   3. Access Superset with locale set to Catalan (`ca`), so gettext uses the 
Catalan catalog
   `superset/translations/ca/LC_MESSAGES/messages.po` where the msgid `This is 
custom error
   message for a` maps to the msgstr on lines `15935-15936`.
   
   4. Observe the rendered error message in the UI: `Aquest és un missatge 
d'error
   personalitzat per a a`, which contains the duplicated visible token `a` 
(`per a a`),
   presenting as a typo to Catalan-speaking users.
   ```
   </details>
   
   [![Fix in 
Cursor](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-cursor-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=5fb3185092e5476482a6af64bd35c33c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
 [![Fix in VSCode 
Claude](https://new-codeant-butcket.s3.us-west-1.amazonaws.com/badges/fix-in-vscode-claude-flat.svg)](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=5fb3185092e5476482a6af64bd35c33c&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
   
   *(Use Cmd/Ctrl + Click for best experience)*
   <details>
   <summary><b>Prompt for AI Agent 🤖 </b></summary>
   
   ```mdx
   This is a comment left during a code review.
   
   **Path:** superset/translations/ca/LC_MESSAGES/messages.po
   **Line:** 15935:15936
   **Comment:**
        *Typo: The translated string has an obvious duplicated token (`a a`), 
which will show a visibly incorrect message in the UI. Keep the final 
identifier as a single token (for example, quoted) so the sentence does not 
contain the duplicated `a`.
   
   Validate the correctness of the flagged issue. If correct, How can I resolve 
this? If you propose a fix, implement it and please make it concise.
   Once fix is implemented, also check other comments on the same PR, and ask 
user if the user wants to fix the rest of the comments as well. if said yes, 
then fetch all the comments validate the correctness and implement a minimal fix
   ```
   </details>
   <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41657&comment_hash=3f97e229b7293de00e8fa51dd667ae7cd349c22739aeb39ec1a583635f5fcedf&reaction=like'>👍</a>
 | <a 
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41657&comment_hash=3f97e229b7293de00e8fa51dd667ae7cd349c22739aeb39ec1a583635f5fcedf&reaction=dislike'>👎</a>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to