bito-code-review[bot] commented on code in PR #40129:
URL: https://github.com/apache/superset/pull/40129#discussion_r3510308926
##########
superset/translations/pt_BR/LC_MESSAGES/messages.po:
##########
@@ -3194,6 +3194,9 @@ msgstr "Alterações no gráfico"
msgid "Chart could not be created."
msgstr "Não foi possível criar o gráfico."
+msgid "Chart could not be restored."
+msgstr ""
Review Comment:
<!-- Bito Reply -->
The suggestion is appropriate for maintaining translation consistency. In
the context of gettext catalogs, while an empty `msgstr` is technically valid
and causes a fallback to the source text, providing the translation ensures
that the application is fully localized for the target language, avoiding
mixed-language interfaces for users.
**superset/translations/pt_BR/LC_MESSAGES/messages.po**
```
msgid "Chart could not be restored."
msgstr "Não foi possível restaurar o gráfico."
```
##########
superset/commands/report/exceptions.py:
##########
@@ -225,6 +225,13 @@ class
ReportScheduleExecuteUnexpectedError(CommandException):
message = _("Report Schedule execution got an unexpected error.")
+class ReportScheduleTargetChartDeletedError(CommandException):
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion to use a 404 status code for the new exception is
based on the pattern of other 'not found' exceptions in the codebase. However,
your assessment that this specific exception should remain a 500 error is
appropriate given that it is raised within the Celery report executor, where a
5xx status is required to trigger the necessary task failure and alerting
mechanisms for ops.
##########
superset/translations/fr/LC_MESSAGES/messages.po:
##########
@@ -3117,6 +3117,9 @@ msgstr "Changements de graphique"
msgid "Chart could not be created."
msgstr "Le graphique n'a pas pu être créé."
+msgid "Chart could not be restored."
+msgstr ""
Review Comment:
<!-- Bito Reply -->
The reviewer's suggestion is correct. In the context of `gettext` and `.po`
files, an empty `msgstr` is the standard way to indicate that a string is
untranslated. This ensures that the application falls back to the source text
(English) for that specific string, which is the expected behavior for newly
added strings until a translator provides the translation.
**superset/translations/fr/LC_MESSAGES/messages.po**
```
+msgid "Chart could not be restored."
+msgstr ""
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
