codeant-ai-for-open-source[bot] commented on code in PR #40129:
URL: https://github.com/apache/superset/pull/40129#discussion_r3510245445
##########
superset/daos/dashboard.py:
##########
@@ -276,11 +277,30 @@ def set_dash_metadata(
if isinstance(value, dict)
]
- current_slices = (
- db.session.query(Slice).filter(Slice.id.in_(slice_ids)).all()
- )
-
- dashboard.slices = current_slices
+ # Bypass the soft-delete visibility filter when resolving the
+ # incoming chart ids: a dashboard's ``position_json`` may still
+ # reference a chart that is currently soft-deleted, and this
+ # assignment REBUILDS ``dashboard.slices`` wholesale. With the
+ # filter active, the hidden member would be silently dropped —
+ # deleting its ``dashboard_slices`` junction row (breaking the
+ # documented restore-reattach contract) and writing
+ # ``uuid: None`` into its position slot via ``uuid_map`` below.
+ #
+ # The bypass must be session-scoped and cover the ASSIGNMENT,
+ # not just the resolution query: assigning to
+ # ``dashboard.slices`` makes the unit of work diff the new
+ # collection against the existing one, which it lazy-loads at
+ # that moment. A filtered baseline load would exclude the
+ # trashed member, so the diff would treat it as net-new and
+ # INSERT a ``dashboard_slices`` row that still exists (soft
+ # delete never removes junction rows) — an IntegrityError on
+ # the composite primary key on every save of a dashboard
+ # containing a trashed chart.
+ with skip_visibility_filter(db.session, Slice):
+ current_slices = (
+
db.session.query(Slice).filter(Slice.id.in_(slice_ids)).all()
+ )
Review Comment:
**Suggestion:** Add an explicit type annotation for the newly introduced
local query result variable to comply with the type-hint requirement for
relevant variables. [custom_rule]
**Severity Level:** Minor ⚠️
<details>
<summary><b>Why it matters? 🤔 </b></summary>
The new local variable `current_slices` is assigned a list of `Slice`
objects but has no type annotation. This matches the rule requiring type hints
for relevant new or modified Python variables that can be annotated.
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=76b953bf2a0345448db26cf5521bb850&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=76b953bf2a0345448db26cf5521bb850&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/daos/dashboard.py
**Line:** 300:302
**Comment:**
*Custom Rule: Add an explicit type annotation for the newly introduced
local query result variable to comply with the type-hint requirement for
relevant variables.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40129&comment_hash=d22994aeb7cacbff1ff49195e461e9f5d559f9db20e668141e985be4ee982740&reaction=like'>👍</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F40129&comment_hash=d22994aeb7cacbff1ff49195e461e9f5d559f9db20e668141e985be4ee982740&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
