vhogberg opened a new pull request, #41678: URL: https://github.com/apache/superset/pull/41678
### SUMMARY Fixes #41677 When drilling to detail by a dimension whose value is null, the context menu previously rendered "Drill to detail by " with a blank value. This was because `formatSeriesName` returns the <NULL> placeholder, but the StyledFilter component ran `removeHTMLTags` on it, which stripped <NULL> as if it were an HTML tag, leaving an empty label. This PRs fixes detects null/empty values (including the existing <NULL> placeholder) and renders them with HTML stripping disabled, so the menu now correctly shows "Drill to detail by <NULL>". Added a unit test in `useDrillDetailMenuItems.test.tsx` covering the null-value case. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: <img width="375" height="242" alt="image" src="https://github.com/user-attachments/assets/d127bea2-6a2b-4607-8cd5-0099512515cf"; /> After: <img width="246" height="147" alt="image" src="https://github.com/user-attachments/assets/faf38f4f-8511-463d-947c-7e0c6ce75b19"; /> ### TESTING INSTRUCTIONS 1. Create a chart with a dimension that has null values 2. Add it to a dashboard 3. Right a chart value and observe "Drill to detail by <NULL>" now, rather than "Drill to detail by ". ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
