bito-code-review[bot] commented on PR #41678:
URL: https://github.com/apache/superset/pull/41678#issuecomment-4863311729
<!-- Bito Reply -->
The flagged issue is correct. The current logic
`isEmpty(filter.formattedVal) || filter.formattedVal === NULL_STRING`
incorrectly treats empty strings as null values, which mislabels them in the
UI. To resolve this, you should restrict the null check to explicitly verify
against the null marker, ensuring empty strings are preserved as valid values.
Here is the corrected logic for
`superset-frontend/src/components/Chart/useDrillDetailMenuItems/index.tsx`:
```tsx
const isNullVal =
filter.val === null || filter.formattedVal === NULL_STRING;
const formattedVal = isNullVal
? NULL_STRING
: filter.formattedVal;
```
I have checked the PR comments, and there are no other review comments to
address. Would you like me to perform any further analysis?
**superset-frontend/src/components/Chart/useDrillDetailMenuItems/index.tsx**
```
const isNullVal =
filter.val === null || filter.formattedVal === NULL_STRING;
const formattedVal = isNullVal
? NULL_STRING
: filter.formattedVal;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
