rusackas opened a new pull request, #41728:
URL: https://github.com/apache/superset/pull/41728

   ### SUMMARY
   
   Tier 3 of #41714 (targets `remove-legacy-viz-pipeline`): retire the nvd3 
**Bubble Chart (`bubble`)** by migrating saved charts to the ECharts **Bubble 
Chart (`bubble_v2`)**.
   
   - The `MigrateBubbleChart` processor (with CLI registration and unit tests) 
has existed since the ECharts bubble shipped, but **no Alembic revision ever 
invoked it** — so legacy bubble charts kept rendering through `explore_json`. 
This PR adds the revision: `d4e5f6a7b8c9`, with the standard MySQL MEDIUMTEXT 
widening and reversible `form_data_bak` backups (same shape as the 
treemap/sunburst/5.0-batch migrations).
   - Removes the nvd3 Bubble plugin (`legacy-preset-chart-nvd3/src/Bubble/`), 
its MainPreset + preset registrations, the dead `BubbleViz` backend class, and 
the bubble branch of the shared NVD3 renderer.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Saved legacy bubble charts re-open as ECharts Bubble Charts (the same 
auto-migration path already used for line/area/bar/dist_bar in 5.0).
   
   ### TESTING INSTRUCTIONS
   
   - `pytest 
tests/unit_tests/migrations/viz/nvd3_bubble_chart_to_echarts_test.py` passes 
(pre-existing processor test).
   - `npm run test -- plugins/legacy-preset-chart-nvd3` passes.
   - Manual: `superset db upgrade` then open a formerly-legacy bubble chart — 
renders as `bubble_v2`; `superset db downgrade` restores the original form_data 
from the backup.
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [x] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [x] Migration is atomic, supports rollback & is backwards-compatible
     - [x] Confirm DB migration upgrade and downgrade tested
     - [x] Runtime estimates and downtime expectations provided: proportional 
to the number of saved `bubble` slices (same paginated_update pattern as prior 
viz migrations); no downtime expected
   - [ ] Introduces new feature or API
   - [x] Removes existing feature or API
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to