codeant-ai-for-open-source[bot] commented on code in PR #41728: URL: https://github.com/apache/superset/pull/41728#discussion_r3517869022
########## superset/migrations/versions/2026-07-02_21-00_d4e5f6a7b8c9_migrate_bubble_chart_to_echarts.py: ########## @@ -0,0 +1,55 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""migrate_bubble_chart_to_echarts + +Revision ID: d4e5f6a7b8c9 +Revises: a7d3f1b9c2e4 +Create Date: 2026-07-02 21:00:00.000000 + +""" + +from alembic import op +from sqlalchemy import text +from sqlalchemy.dialects.mysql.base import MySQLDialect + +from superset import db +from superset.migrations.shared.migrate_viz import MigrateBubbleChart + +# revision identifiers, used by Alembic. +revision = "d4e5f6a7b8c9" +down_revision = "a7d3f1b9c2e4" + + +def upgrade(): Review Comment: **Suggestion:** Add an explicit return type hint to this migration function (for example, annotate it as returning no value) to satisfy the type-hint requirement for new Python functions. [custom_rule] **Severity Level:** Minor ⚠️ <details> <summary><b>Why it matters? 🤔 </b></summary> The custom rule requires type hints on new or modified Python functions when they can be annotated. `upgrade()` has no return type annotation, so this is a real violation. </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=fa66d3fc85704174b98d1cda5e9da918&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=fa66d3fc85704174b98d1cda5e9da918&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/migrations/versions/2026-07-02_21-00_d4e5f6a7b8c9_migrate_bubble_chart_to_echarts.py **Line:** 37:37 **Comment:** *Custom Rule: Add an explicit return type hint to this migration function (for example, annotate it as returning no value) to satisfy the type-hint requirement for new Python functions. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41728&comment_hash=498d4aca899b6560e457086598ed86ba5096ea6a8590229e5df130a6f25de79d&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41728&comment_hash=498d4aca899b6560e457086598ed86ba5096ea6a8590229e5df130a6f25de79d&reaction=dislike'>👎</a> ########## superset/migrations/versions/2026-07-02_21-00_d4e5f6a7b8c9_migrate_bubble_chart_to_echarts.py: ########## @@ -0,0 +1,55 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +"""migrate_bubble_chart_to_echarts + +Revision ID: d4e5f6a7b8c9 +Revises: a7d3f1b9c2e4 +Create Date: 2026-07-02 21:00:00.000000 + +""" + +from alembic import op +from sqlalchemy import text +from sqlalchemy.dialects.mysql.base import MySQLDialect + +from superset import db +from superset.migrations.shared.migrate_viz import MigrateBubbleChart + +# revision identifiers, used by Alembic. +revision = "d4e5f6a7b8c9" +down_revision = "a7d3f1b9c2e4" + + +def upgrade(): + bind = op.get_bind() + + # Ensure `slice.params` and `slice.query_context` in MySQL is MEDIUMTEXT + # before migration, as the migration will save a duplicate form_data backup + # which may significantly increase the size of these fields. + if isinstance(bind.dialect, MySQLDialect): + # If the columns are already MEDIUMTEXT, this is a no-op + op.execute(text("ALTER TABLE slices MODIFY params MEDIUMTEXT")) + op.execute(text("ALTER TABLE slices MODIFY query_context MEDIUMTEXT")) Review Comment: **Suggestion:** Replace the raw `ALTER TABLE` SQL execution with database-compatible migration helpers from `superset.migrations.shared.utils` (such as column-inspection plus dialect-safe alter operations) instead of direct SQL text statements. [custom_rule] **Severity Level:** Minor ⚠️ <details> <summary><b>Why it matters? 🤔 </b></summary> This migration directly executes raw ALTER TABLE SQL text for MySQL-specific schema changes instead of using shared compatibility helpers from `superset.migrations.shared.utils`, which matches the rule violation described. </details> [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=f781ce1a4b724464b63f010d30a9216d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=f781ce1a4b724464b63f010d30a9216d&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) *(Use Cmd/Ctrl + Click for best experience)* <details> <summary><b>Prompt for AI Agent 🤖 </b></summary> ```mdx This is a comment left during a code review. **Path:** superset/migrations/versions/2026-07-02_21-00_d4e5f6a7b8c9_migrate_bubble_chart_to_echarts.py **Line:** 45:46 **Comment:** *Custom Rule: Replace the raw `ALTER TABLE` SQL execution with database-compatible migration helpers from `superset.migrations.shared.utils` (such as column-inspection plus dialect-safe alter operations) instead of direct SQL text statements. Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise. Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix ``` </details> <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41728&comment_hash=4cb72a1ed4f27f1c44752cf3b5e4dfc5df993f8ee0d19339c69032cd25ea29fe&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F41728&comment_hash=4cb72a1ed4f27f1c44752cf3b5e4dfc5df993f8ee0d19339c69032cd25ea29fe&reaction=dislike'>👎</a> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
