rusackas opened a new pull request, #41732: URL: https://github.com/apache/superset/pull/41732
### SUMMARY Follow-up to #41725/#41726 (targets `remove-legacy-viz-pipeline`): a bot review on the partition PR pointed out that the legacy line engine (`NVD3TimeSeriesViz.query_obj`) always ordered by the sort metric *or the first selected metric*, ascending unless `order_desc`. The horizon and rose buildQueries had dropped that default ordering, which changes which rows survive `row_limit` truncation. Restored, with tests pinning both directions. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF N/A — query ordering parity only. ### TESTING INSTRUCTIONS `npm run test -- plugins/legacy-plugin-chart-horizon plugins/legacy-plugin-chart-rose` — 18 tests pass. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Introduces new feature or API - [x] Removes existing feature or API 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
